-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ThrownExceptionNotInFunction rule to the Analyzer Plugin #585
Open
halotukozak
wants to merge
11
commits into
master
Choose a base branch
from
500-handle-thrown-exception-outside-the-monadic-context-of-task
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add ThrownExceptionNotInFunction rule to the Analyzer Plugin #585
halotukozak
wants to merge
11
commits into
master
from
500-handle-thrown-exception-outside-the-monadic-context-of-task
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #500 |
It's a draft. We can consider wider solution to warn when |
ddworak
requested changes
Jun 13, 2024
analyzer/src/main/scala/com/avsystem/commons/analyzer/ThrownExceptionNotInMonixScope.scala
Outdated
Show resolved
Hide resolved
analyzer/src/main/scala/com/avsystem/commons/analyzer/ThrownExceptionNotInMonixScope.scala
Outdated
Show resolved
Hide resolved
halotukozak
changed the title
add ThrownExceptionNotInMonixScope rule to the Analyzer Plugin
add ThrownExceptionNotInFunction rule to the Analyzer Plugin
Jun 18, 2024
…. The Scala compiler loves to infer Nothing as a generic type but that is almost always incorrect. Explicit type arguments should be used instead.
…her type. The Scala compiler loves to infer Nothing as a generic type but that is almost always incorrect. Explicit type arguments should be used instead." This reverts commit 9622a3f.
halotukozak
force-pushed
the
500-handle-thrown-exception-outside-the-monadic-context-of-task
branch
from
June 19, 2024 08:55
fffed2f
to
ae2b07a
Compare
halotukozak
force-pushed
the
500-handle-thrown-exception-outside-the-monadic-context-of-task
branch
from
June 24, 2024 15:53
32644de
to
0c3b54c
Compare
…side-the-monadic-context-of-task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.